[U-Boot] [PATCH 2/3] A320: driver for FTRTC010 real time clock

[Jean-Christophe PLAGNIOL-VILLARD]

> +
> +static volatile struct ftrtc010 *rtc = (struct ftrtc010 *)CONFIG_SYS_RTC_BASE;
> +
> +static void ftrtc_enable (void)
you use it at one please only the reset
> +{
> +	rtc->cr = cpu_to_le32 (FTRTC010_CR_ENABLE);
so please move this code there
> +}
> +
> +/*
> + * return current time in seconds
> + */
> +static unsigned long ftrtc_time (void)
> +{
> +	unsigned long day;
> +	unsigned long hour;
> +	unsigned long minute;
> +	unsigned long second;
> +	unsigned long second2;
> +
> +	do {
> +		second	= le32_to_cpu (rtc->sec);
please use proper accessor
readl/writel

Best Regards,
J.