[U-Boot] [PATCH] Kirkwood: add Marvell Sheevaplug gpio support

[Dieter Kiermaier]

> 
> > -----Original Message-----
> > From: Dieter Kiermaier [mailto:dk-arm-linux at gmx.de] 
> > Sent: Monday, June 29, 2009 1:33 PM
> > To: u-boot at lists.denx.de
> > Cc: Prafulla Wadaskar
> > Subject: [PATCH] Kirkwood: add Marvell Sheevaplug gpio support
> > 
> > Hi List,
> > 
> > this if my first patch which goes to the wild. So please 
> > don't be croos with me if I made some stupid thing :) Any 
> > comments or feedback would be very welcome!
> > 
> > Is it common that the patch writer gives his Signed-off-by or 
> > who is responsible for that?
> > 
> > Cheers,
> > Dieter
> > 
> > 
> > From e89ebedf1528e821e504c91af802687efb21533b Mon Sep 17 00:00:00 2001
> > From: Dieter Kiermaier <dk-arm-linux at gmx.de>
> > Date: Fri, 26 Jun 2009 14:45:13 +0200
> > Subject: [PATCH] Kirkwood: add Marvell Sheevaplug gpio support
> Signed-off-by is MUST
> 
Ok
> > 
> > ---
> >  board/Marvell/sheevaplug/sheevaplug.c |    1 +
> >  cpu/arm926ejs/kirkwood/Makefile       |    1 +
> >  cpu/arm926ejs/kirkwood/gpio.c         |  144 
> > +++++++++++++++++++++++++++++++++
> >  include/asm-arm/arch-kirkwood/gpio.h  |   43 ++++++++++
> Spilt this patch into two, 1. gpio support for Kirkwood SOC and 2. Sheevaplug updates
You think about the change in sheevaplug.c for "2. Sheevaplug updates" , right?


> Move gpio stuff to drivers/gpio/
ok

> 
> >  4 files changed, 189 insertions(+), 0 deletions(-)  create 
> > mode 100644 cpu/arm926ejs/kirkwood/gpio.c  create mode 100644 
> > include/asm-arm/arch-kirkwood/gpio.h
> > 
> > diff --git a/board/Marvell/sheevaplug/sheevaplug.c 
> > b/board/Marvell/sheevaplug/sheevaplug.c
> > index 547126a..fa28fea 100644
> > --- a/board/Marvell/sheevaplug/sheevaplug.c
> > +++ b/board/Marvell/sheevaplug/sheevaplug.c
> > @@ -26,6 +26,7 @@
> >  #include <miiphy.h>
> >  #include <asm/arch/kirkwood.h>
> >  #include <asm/arch/mpp.h>
> > +#include <asm/arch/gpio.h>
> >  #include "sheevaplug.h"
> >  
> >  DECLARE_GLOBAL_DATA_PTR;
> > diff --git a/cpu/arm926ejs/kirkwood/Makefile 
> > b/cpu/arm926ejs/kirkwood/Makefile index d73e210..bd6e773 100644
> > --- a/cpu/arm926ejs/kirkwood/Makefile
> > +++ b/cpu/arm926ejs/kirkwood/Makefile
> > @@ -28,6 +28,7 @@ LIB	= $(obj)lib$(SOC).a
> >  
> >  COBJS-y	= dram.o
> >  COBJS-y	+= cpu.o
> > +COBJS-y	+= gpio.o
> It would be good if you use CONFIG_KIRKWOOD_GPIO to enable this, since gpio support may not be required on other platforms
> 
OK
> >  COBJS-y	+= mpp.o
> >  COBJS-y	+= timer.o
> >  
> > diff --git a/cpu/arm926ejs/kirkwood/gpio.c 
> > b/cpu/arm926ejs/kirkwood/gpio.c new file mode 100644 index 
> > 0000000..2cf1eb2
> > --- /dev/null
> > +++ b/cpu/arm926ejs/kirkwood/gpio.c
> > @@ -0,0 +1,144 @@
> > +/*
> > + * arch/arm/plat-orion/gpio.c
> > + *
> > + * Marvell Orion SoC GPIO handling.
> > + *
> > + * This file is licensed under the terms of the GNU General Public
> > + * License version 2.  This program is licensed "as is" without any
> > + * warranty of any kind, whether express or implied.
> > + */
> Have you created this file or fetched from kernel?
I've fetched it from kernel - how should i document this?
Is the kernel revision also needed?

Thanks,
Dieter
> 
> Regards..
> Prafulla . .
>