[U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

Michael Trimarchi trimarchi at gandalf.sssup.it
Mon Jun 29 14:17:52 CEST 2009


Prafulla Wadaskar wrote:
> Signed-off-by: Prafulla Wadaskar <prafulla at marvell.com>
> ---
>  drivers/usb/host/ehci-hcd.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index bbd547b..7a55638 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -550,7 +550,7 @@ ehci_submit_root(struct usb_device *dev, unsigned long pipe, void *buffer,
>  	      req->requesttype, req->requesttype,
>  	      le16_to_cpu(req->value), le16_to_cpu(req->index));
>  
> -	typeReq = req->request << 8 | req->requesttype;
> +	typeReq = req->request | req->requesttype << 8;
>   
Sorry, but I'm not sure in this inversion. Are your sure?

>  
>  	switch (le16_to_cpu(typeReq)) {
>   
Maybe this one has no sense...
Michael
>  	case DeviceRequest | USB_REQ_GET_DESCRIPTOR:
>   



More information about the U-Boot mailing list