[U-Boot] [PATCH] xscale: add support for the polaris board

[Jean-Christophe PLAGNIOL-VILLARD]

On 09:00 Mon 29 Jun     , stefano babic wrote:
> Jean-Christophe PLAGNIOL-VILLARD wrote:
> >>  MAINTAINERS                 |    4 ++++
> > please add it in the MAKEALL
> 
> Right. I will fix it.
> 
> >> -void usb_board_init(void)
> >> +int usb_board_init(void)
> >>  {
> >>  	UHCHR = (UHCHR | UHCHR_PCPL | UHCHR_PSPL) &
> >>  		~(UHCHR_SSEP0 | UHCHR_SSEP1 | UHCHR_SSEP2 | UHCHR_SSE);
> >> @@ -71,6 +76,8 @@ void usb_board_init(void)
> >>  
> >>  	/* Set port power control mask bits, only 3 ports. */
> >>  	UHCRHDB |= (0x7<<17);
> >> +
> >> +	return 0;
> >>  }
> > why?
> 
> The usb_board_init() prototype was changed sometimes ago and now the
> return value is checked (it was not when the trizeps module was added to
> u-boot). So now the usb initialization can fail (and it does..).
> 
> To be honest, this fix is not related to this patch, but because it is
> a small change I inserted here. Should be enough if I add a comment
> about it in the git commit or do you think it is required to pull it
> apart in an another patch ?
please
> 
> >>  #define CONFIG_BOOTDELAY	3
> >> -#define CONFIG_SERVERIP		192.168.1.99
> > not related to this patch
> 
> You are right, I will drop this change here and I will send another
> patch to clean up these parameters (and CONFIG_EXTRA_ENV_SETTINGS, too).
> 
> >>  
> >> -#define CONFIG_NET_MULTI		1
> >> +#define CONFIG_NET_MULTI		0
> > ???
> 
> There is only one ethernet controller available and for this reason I
> cleared the NET_MULTI flag. However, I see other boards use another
> approach and leave this flag set. I can let the same approach here.
IIRC we you check the ifdef only not the value

Best Regards,
J.