[U-Boot] [patch] csb337 board support (ARM at91rm9200)

[Jean-Christophe PLAGNIOL-VILLARD]

> > >   - USB didn't work; the software wouldn't detect usb-storage devices.
> > >     So it's not yet enabled.
> >
> > what is the power on the USB?
> 
> I don't understand the question.  5V of course.  Not switchable.
is the usb provide enough power to supply the usb key
> 
>  
> > >   - There seems to be some issue copying lots of data from NOR flash.
> > >     It works OK in chunks of up to 512 KB or so, but copying a kernel
> > >     (1.4 MB) failed ... copying *way* over 15 MBytes, and trashing
> > >     the DRAM image of U-Boot that was running.  (Compiler issue?)
> >
> > Clock issue ot RAM timing issue
> 
> Doesn't quite make sense.  Something clobbered a termination
> condition, which would be in a register, or at worst in cache.
> 
> How would RAM timing cause breakage?  The data copied was
> correct, in smaller chunks, and the termination condition
> wasn't stored in RAM.  Or a clock issue, considering all the
> relevant cycles are inside the arm920t core?
> 
> I like the "compiler issue" theory better.  :(
> 
>  
> > >  board/csb337/u-boot.lds  |   56 +++++++++++
> >
> > no need please remove
> 
> In mainline u-boot it seems to be needed.  Can you maybe push your
> first set of patches to Wolfgang, which consolidate all
> that stuff?
the arm work need to be based on u-boot-arm tree
> 
> 
> > > +#if defined(CONFIG_DRIVER_ETHER) && defined(CONFIG_CMD_NET)
> > it will be better ot manage this in the config header
> 
> You mean by defining an otherwise needless symbol,
> along the lines of CONFIG_SYS_AT91RM9200_LXT_PHY?
CONFIG_DRIVER_EHTER will be enough
> 
> Probably simpler just always include those few lines,
> and not support building without Ethernet.
> 
> 
> > > +
> > > +/* The AT91 lxt972 glue modified the original lxt971 code by
> > > + * changing names and generalizing a bit.  So we use "lxt972"
> > > + * names here even though the CSB337 has an lxt971 chip.
> > > + */
> > > +extern unsigned char lxt972_InitPhy(AT91S_EMAC *mac);
> > > +extern unsigned lxt972_IsPhyConnected(AT91S_EMAC *mac);
> > > +extern unsigned char lxt972_GetLinkSpeed(AT91S_EMAC *mac);
> > > +extern unsigned char lxt972_AutoNegotiate(AT91S_EMAC *mac, int *status);
> > :(
> > please a header
> 
> I'll stick it in hardware.h ... you can remove similar decls
> from other rm9200 boards then.
a phy header will be better IMHO
> 
> > > +
> > > +#if 0
> > please 
> > if CONFIG_CMD_USB
> > > +/* REVISIT:  USB failed to enumerate devices of any kind ... sw issues */
> 
> An #if 0 won't work without completely re-whacking things.
> 
> Right now the commands kick in *MUCH LATER* depending on
> whether the driver is available.  And here, the driver
> (CONFIG_USB_OHCI_NEW driver) and its support is disabled
> since it's not working...
so move it

Best Regards,
J.