[U-Boot] [PATCH 1/2] at91sam9: add watchdog support

[Wolfgang Denk]

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <1232623377-26351-2-git-send-email-plagnioj at jcrosoft.com> you wrote:
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> ---
>  Makefile                             |    1 +
>  doc/README.at91                      |    9 ++++
>  drivers/serial/atmel_usart.c         |    4 +-
>  drivers/watchdog/Makefile            |   46 ++++++++++++++++++++
>  drivers/watchdog/at91sam9_wdt.c      |   79 ++++++++++++++++++++++++++++++++++
>  include/asm-arm/arch-at91/at91_wdt.h |   38 ++++++++++++++++
>  6 files changed, 176 insertions(+), 1 deletions(-)
>  create mode 100644 drivers/watchdog/Makefile
>  create mode 100644 drivers/watchdog/at91sam9_wdt.c
>  create mode 100644 include/asm-arm/arch-at91/at91_wdt.h
> 
> diff --git a/Makefile b/Makefile
> index 4a3a488..c3f089d 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -266,6 +266,7 @@ LIBS += drivers/rtc/librtc.a
>  LIBS += drivers/serial/libserial.a
>  LIBS += drivers/usb/libusb.a
>  LIBS += drivers/video/libvideo.a
> +LIBS += drivers/watchdog/libwatchdog.a
>  LIBS += common/libcommon.a
>  LIBS += libfdt/libfdt.a
>  LIBS += api/libapi.a
> diff --git a/doc/README.at91 b/doc/README.at91
> index 4e3928a..1ef3b2a 100644
> --- a/doc/README.at91
> +++ b/doc/README.at91
> @@ -2,6 +2,7 @@ Atmel AT91 Evaluation kits
>  
>  http://atmel.com/dyn/products/tools.asp?family_id=605#1443
>  
> +I. Board mapping & boot media
>  ------------------------------------------------------------------------------
>  AT91SAM9260EK & AT91SAM9XEEK
>  ------------------------------------------------------------------------------
> @@ -86,3 +87,11 @@ Environment variables
>  		make at91sam9263ek_config		- use data flash (spi cs0) (default)
>  		make at91sam9263ek_nandflash_config	- use nand flash
>  		make at91sam9263ek_dataflash_cs0_config	- use data flash (spi cs0)
> +
> +II. Watchdog support
> +
> +	The watchdog can only be activate once so you need to activate in the
> +	bootloader and in the bootstrap if you use it

This sentence makes no sense to me.

If I can activate it only once, then why do you claim I have to
activate it twice ("in the bootloader [1] and in the bootstrap [2]").

And what exaxctly is "the bootstrap"?

Also note a spelling error: Please write "...can only be activated".

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
You Don't Have To Be 'Damned' To Work Here, But It Helps!!!
                                             - Terry Pratchett, _Eric_