[U-Boot] [PATCH] Seperate mtdpart command from jffs2

[Stefan Roese]

On Monday 09 March 2009, Kyungmin Park wrote:
> >> +++ b/common/Makefile
> >> @@ -98,6 +98,7 @@ COBJS-$(CONFIG_CMD_IMMAP) += cmd_immap.o
> >>  COBJS-$(CONFIG_CMD_IRQ) += cmd_irq.o
> >>  COBJS-$(CONFIG_CMD_ITEST) += cmd_itest.o
> >>  COBJS-$(CONFIG_CMD_JFFS2) += cmd_jffs2.o
> >> +COBJS-$(CONFIG_JFFS2_CMDLINE) += cmd_mtdparts.o
> >
> > Shouldn't we change this define (CONFIG_JFFS2_CMDLINE) to something else
> > now, since it's not really JFFS2 specific anymore? I suggest to change it
> > to CONFIG_CMD_MTDPARTS. This seems more logical to me.
> >
> > What do you think?
>
> It's already done by Jean-Christophe PLAGNIOL-VILLARD. Isn't it?

Is it? I have not seen such a patch. Do you have a link? (I added 
Jean-Christophe to CC).

> > This patch also breaks (at least some) boards with JFFS2 support:
> >
> > [stefan at kubuntu u-boot (master)]$ ./MAKEALL fx12mm
> > Configuring for fx12mm board...
> > cmd_jffs2.c:164: warning: 'device_validate' defined but not used
> > cmd_jffs2.c:220: warning: 'id_parse' defined but not used
> > common/libcommon.a(cmd_flash.o): In function `do_protect':
> > /home/stefan/git/u-boot/u-boot/common/cmd_flash.c:568: undefined
> > reference to `id_parse'
> > common/libcommon.a(cmd_flash.o): In function `do_flerase':
> > /home/stefan/git/u-boot/u-boot/common/cmd_flash.c:362: undefined
> > reference to `id_parse'
> > make: *** [u-boot] Error 1
> > ppc_4xx-size: './u-boot': No such file
> >
> >
> > I didn't try to solve this problem (yet). Perhaps you have an idea?
>
> In both case jffs2 and mtdpart, have id_parse as changed to static, so
> one of both should be non-static. I think remove static at cmd_jffs2.c

It would be great if you could fix this issue in your next patch version.

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================