[U-Boot] [PATCH 7/9] at91rm9200: fix DCC support

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Mon Mar 9 09:36:49 CET 2009


On 00:31 Mon 09 Mar     , Wolfgang Denk wrote:
> Dear Jean-Christophe PLAGNIOL-VILLARD,
> 
> In message <1236089265-24598-7-git-send-email-plagnioj at jcrosoft.com> you wrote:
> > Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj at jcrosoft.com>
> > ---
> >  cpu/arm920t/at91rm9200/interrupts.c |    2 ++
> >  1 files changed, 2 insertions(+), 0 deletions(-)
> 
> Please explain which problem you are trying to fix.
> 
> > diff --git a/cpu/arm920t/at91rm9200/interrupts.c b/cpu/arm920t/at91rm9200/interrupts.c
> > index 5f0703c..3e35f68 100644
> > --- a/cpu/arm920t/at91rm9200/interrupts.c
> > +++ b/cpu/arm920t/at91rm9200/interrupts.c
> > @@ -179,8 +179,10 @@ void reset_cpu (ulong ignored)
> >  	AT91PS_PIO pio = AT91C_BASE_PIOA;
> >  #endif
> >  
> > +#if defined(CONFIG_DBGU) || defined(CONFIG_USART0) || defined(CONFIG_USART1)
> >  	/*shutdown the console to avoid strange chars during reset */
> >  	us->US_CR = (AT91C_US_RSTRX | AT91C_US_RSTTX);
> > +#endif
> 
> Why the #ifdef? Shutting down the console seems a good thing to me.
when using DCC we will not activate the at91 uart at all so we do not have to
shut it down

Best Regards,
J.


More information about the U-Boot mailing list