[U-Boot] [PATCH] 83xx: correctly set encryption and I2C bus 0 clock

Wolfgang Denk wd at denx.de
Thu Mar 12 11:06:12 CET 2009


Dear Norbert van Bolhuis,

In message <49B8B26B.4090104 at aimvalley.nl> you wrote:
>
> Yes I just cut-n-pasted it.
> I hope it's better now.

No, it is not better.

Patches should be sent inline, and not as attachments. It would be
best if you used git-send-email to post the patch.

Also, your Signed-off-by: line is missing in the patch.

And it would be better if you used git-format-patch to create the
patch.


Sorry for the trouble for a one-line-fix, but I think it is important
to learn these things right in the beginning - the less efforts  will
be there when it comes to real work.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Nothing ever becomes real till it is experienced -- even a proverb is
no proverb to you till your life has illustrated it.     - John Keats


More information about the U-Boot mailing list