[U-Boot] [PATCH V2] example/standalone: introduce STANDALONE_LOAD_ADDR

[Mike Frysinger]

On Saturday 14 March 2009 09:19:01 Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 09:12 Sat 14 Mar     , Mike Frysinger wrote:
> > On Saturday 14 March 2009 08:45:56 Jean-Christophe PLAGNIOL-VILLARD wrote:
> > > On 07:37 Sat 14 Mar     , Mike Frysinger wrote:
> > > > On Saturday 14 March 2009 07:13:02 Jean-Christophe wrote:
> > > > > that could be overwrite in following order
> > > > > ARCH
> > > > > CPU
> > > > > SOC
> > > > > BOARD
> > > > >
> > > > > via the corresponding config.mk
> > > >
> > > > the idea sounds fine to me ...
> > > >
> > > > > the value could be exported to the environment to reduce the user
> > > > > mistake when they try to use example's standalone application
> > > >
> > > > i dont really understand what you're trying to say here.  could you
> > > > elaborate so we can fix up the changelog ?
> > >
> > > as example generate via the config.h a env var name
> > > standalone_load_addr automaticly so the end user will just have to
> > > built it, load it and run it
> >
> > i still dont get it.  config.h is the shortcut header to get at the board
> > config.h.  defines do not randomly get exported from there into the
> > environment.  the autoconf.mk mechanism only exports CONFIG_* stuff.
>
> via the board config.h you could add default extra env settings by doing
> this as example
>
> #define CONFIG_EXTRA_ENV_SETTINGS
> "standalone_load_addr="xstr(STANDALONE_LOAD_ADDR)

so you're talking about the u-boot runtime environment, not the u-boot build 
environment.

i dont think your example here is the whole story.  nothing moves the u-boot 
make var STANDALONE_LOAD_ADDR from the env into CPPFLAGS / define.  so you 
would also need to add to some .mk somewhere:
CPPFLAGS += -DSTANDALONE_LOAD_ADDR=$(STANDALONE_LOAD_ADDR)

probably best if you just deleted that last paragraph from the commit message 
since it's too vague to be useful imo.
-mike