[U-Boot] [PATCH 7/7] Save the env variables to SDcard and SPI flash for MPC8536DS

[Wolfgang Denk]

Dear Mingkai Hu,

In message <1237171943-11938-7-git-send-email-Mingkai.hu at freescale.com> you wrote:
> MPC8536DS offer booting from SDcard or SPI flash. When after
> booting from SD card/SPI flash, the environment variables can
> to be saved on it, so this patch should be used together with
> the MMC driver and eSPI controller/SPI flash driver in u-boot.
> 
> Signed-off-by: Mingkai Hu <Mingkai.hu at freescale.com>
...

> +#if !defined(CONFIG_SDCARD_U_BOOT)
...

Please swap cases and use positive logic.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Am I your nanny? The kernel is there to support  user  programs,  but
it's a _resource_ handler, not a baby feeder.     - Linus Torvalds in
      <Pine.LNX.3.91.960425074845.22041C-100000 at linux.cs.Helsinki.FI>