[U-Boot] [PATCH 1/8 v2] UBIFS: Implement read-only UBIFS support in U-Boot (Part 1)

Stefan Roese sr at denx.de
Thu Mar 19 10:27:54 CET 2009


Hi Wolfgang,

On Wednesday 18 March 2009, Wolfgang Denk wrote:
> > This patchset adds UBIFS read-only support to U-Boot. The following
> > commands are implemented:
> >
> > - ubifsmount
> >   Mount an UBIFS volume
> >
> > - ubifsls
> >   List a directory of the mounted UBIFS volume
> >
> > - ubifsload
> >   Load a file from the mounted UBIFS volume to memory
> >
> > The U-Boot UBIFS implementation is largely a direct copy from the current
> > Linux version (2.6.29-rc6). As already done in the UBI version we have an
> > "abstraction layer" to redefine or remove some OS calls (e.g.
> > mutex_lock() ...). This makes it possible to use the original Linux code
> > with very little changes. And by this we can better update to later Linux
> > versions.
> >
> > I removed some of the Linux features that are not used in the U-Boot
> > version (e.g. garbage-collection, write support).
> >
> > Signed-off-by: Stefan Roese <sr at denx.de>
> > CC: Artem Bityutskiy <dedekind at infradead.org>
> > CC: Adrian Hunter <ext-Adrian.Hunter at nokia.com>
>
> I don't understand the split of this patchset into 8 patches, which
> all use the very same subject (= commit title line) and commit
> message.
>
> It seems the splitting was done just for size reasons, not taking into
> account any logic parts that belong together or bi-sectability.

Correct. Even though it should still be git bisectable.

> Please explain why this is not just a single commit?

Sure. It's the list limit. It was my understanding that patches > 100k usually 
are not accepted on the list. This UBIFS support is approx. 500k in total, so 
I didn't even try to send it as a single patch.

OK, I'll send the patch to list again in a short while.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================


More information about the U-Boot mailing list