[U-Boot] [PATCH v2] UBIFS: Missing offset relocation for compressor 'none'

Wolfgang Denk wd at denx.de
Fri Mar 20 22:13:54 CET 2009


Dear Michael Lawnick,

In message <49C20B21.1080005 at gmx.de> you wrote:
> On systems where U-Boot is linked to another address than it really lays
> (e.g. backup image), calls via function pointers must be fixed with a
> '+= gd->reloc_off'.
> This was not done for none_compr in ubifs_compressors_init() what leads
> to system crash on ubifsmount command.
> 
> Signed-off-by: Michael Lawnick <ml.lawnick at gmx.de>
> ---
>  fs/ubifs.c |    5 +-
>  1 files changed, 4 insertions(+), 1 deletions(-)
> 
> diff -Naur a/fs/ubifs/ubifs.c b/fs/ubifs/ubifs.c
> --- a/fs/ubifs/ubifs.c 2009-02-20 16:02:44.434443000 +0100
> +++ b/fs/ubifs/ubifs.c 2009-03-18 16:06:09.000000000 +0100
> 
> @@ -147,7 +147,10 @@ int __init ubifs_compressors_init(void)
>         if (err)
>                 return err;
> 
> -       ubifs_compressors[UBIFS_COMPR_NONE] = &none_compr;
> +       err = compr_init(&none_compr);
> +       if (err)
> +               return err;
> +
>         return 0;
>  }

Applied (with manual fixing) to "next" branch.

Please do not hand-edit your patches, resp. make sure to use
git-send-email to submit the poatches.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Motto of the Electrical Engineer: Working computer hardware is a  lot
like an erect penis: it stays up as long as you don't fuck with it.


More information about the U-Boot mailing list