[U-Boot] [PATCH 1/3] mpc5200: do not use printf in i2c_init()

Wolfgang Denk wd at denx.de
Sat Mar 21 20:47:33 CET 2009


Dear Jon,

In message <20090321133844.11905.61201.stgit at localhost> you wrote:
> From: Sascha Hauer <s.hauer at pengutronix.de>
> 
> On boards which have the environment in eeprom, i2c_init()
> is called before the console and ram is initialized. Do
> not printf here.
> 
> Signed-off-by: Sascha Hauer <s.hauer at pengutronix.de>
> ---
>  cpu/mpc5xxx/i2c.c |   10 ----------
>  1 files changed, 0 insertions(+), 10 deletions(-)

Rather than doing this unconsitionally, this change should only be
implemented on boards which actually hold the envrionment in I2C
EEPROM (alternatively, one should consider fixing these boards to use
more appropriate storage; in addition to being not reliable, I2C
EEPROM is slow - see
http://www.denx.de/wiki/DULG/AN2004_11_BootTimeOptimization )

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"Bureaucracy is the enemy of innovation."
       - Mark Shepherd, former President and CEO of Texas Instruments


More information about the U-Boot mailing list