[U-Boot] [PATCH 1/3] mpc5200: do not use printf in i2c_init()

Wolfgang Denk wd at denx.de
Sun Mar 22 15:21:01 CET 2009


Dear Jon,

In message <9e4733910903220701h104932cdu6b226e5c05e9b3d4 at mail.gmail.com> you wrote:
>
> I've test this version with the eeprom and it works correctly.

It may work, but such a macro definition violates some rules.

> +#define printf(format, arg...) if (gd->have_console) printf(format, ## arg)

There are only a few places in cpu/mpc5xxx/i2c.c where printf() is
used that we should explicitly code this, there.

Thanks.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Your own mileage may vary.


More information about the U-Boot mailing list