[U-Boot] [PATCH 1/3] mpc5200: do not use printf in i2c_init()

Wolfgang Denk wd at denx.de
Sun Mar 22 16:23:42 CET 2009


Dear Jon Smirl,

In message <9e4733910903220723u31546286q233c9b24b7a5d53 at mail.gmail.com> you wrote:
>
> Would it be better to put the check for (gd->have_console)  into printf itself?

No, as you could also use puts() or putc().  There  are  only  a  few
isolated  places  where  we  need  this,  so  let's make this clearly
visible there.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
The use of COBOL cripples the mind; its teaching  should,  therefore,
be regarded as a criminal offence.
          -- Edsger W. Dijkstra, SIGPLAN Notices, Volume 17, Number 5


More information about the U-Boot mailing list