[U-Boot] [PATCH 3/3] mpc5200: make i2c faster

Wolfgang Denk wd at denx.de
Mon Mar 23 07:24:23 CET 2009


Dear Grant Likely,

In message <fa686aa40903222000l13369f61gf93b26b4c804e383 at mail.gmail.com> you wrote:
>
> Even better, since this is entirely a busywait, the udelay(1) could be
> dropped entirely and the exit condition be based on the value of
> timebase.  That would give the absolute maximum resolution to the
> busyloop.  However, the incremental improvement probably isn't a great
> deal better than this patch.

I disagree. Keep in mind that on systems with hardware watchdog
enabled udelay() implicitly takes care of triggering the watchdog, so
using it in busy-wait loops is always a good idea.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Build a system that even a fool can use and only a fool will want  to
use it.


More information about the U-Boot mailing list