[U-Boot] [PATCH 1/3] mpc5200: do not use printf in i2c_init()

Heiko Schocher hs at denx.de
Tue Mar 24 09:38:04 CET 2009


Hello Jon,

Jon Smirl wrote:
> On Sun, Mar 22, 2009 at 11:23 AM, Wolfgang Denk <wd at denx.de> wrote:
>   
>> Dear Jon Smirl,
>>
>> In message <9e4733910903220723u31546286q233c9b24b7a5d53 at mail.gmail.com> you wrote:
>>     
>>> Would it be better to put the check for (gd->have_console)  into printf itself?
>>>       
>> No, as you could also use puts() or putc().  There  are  only  a  few
>> isolated  places  where  we  need  this,  so  let's make this clearly
>> visible there.
>>     
>
> mpc5200 with eeprom, suppress printf until console initialized
>
> From: Jon Smirl <jonsmirl at gmail.com>
>
> On boards which have the environment in eeprom, i2c_init()
> is called before the console and ram is initialized. Suppress
> printfs until the console is initialized.
>
> Signed-off-by: Jon Smirl <jonsmirl at gmail.com>
> ---
>  cpu/mpc5xxx/i2c.c |   30 ++++++++++++++++++++----------
>  1 files changed, 20 insertions(+), 10 deletions(-)
>   

Acked-by: Heiko Schocher <hs at denx.de>

bye
Heiko

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany 



More information about the U-Boot mailing list