[U-Boot] [PATCH v2 4/4] Flex-OneNAND boundary setting command

Scott Wood scottwood at freescale.com
Wed Mar 25 18:23:19 CET 2009


On Wed, Mar 25, 2009 at 08:44:37PM +0530, Amul Kumar Saha wrote:
> >> +    die = (int) simple_strtoul(argv[2], NULL, 0);
> >> +    bdry = (int) simple_strtoul(argv[3], NULL, 0);
> > 
> > Casts should not be necessary.
> > 
> 
> I believe that typecasting a UL to an int, is OK.
> Do let me know.

The compiler will implicitly cast unsigned long to int.  The explicit cast
is unnecessary clutter which makes it harder to find casts that aren't OK.

-Scott


More information about the U-Boot mailing list