[U-Boot] [PATCH] NetLoop initialization bug

Wolfgang Denk wd at denx.de
Mon Mar 30 09:45:32 CEST 2009


Dear Heiko,

In message <49D054BA.1060904 at denx.de> you wrote:
> 
> The following 2 vars are just used, if CONFIG_CMD_CDP
> is used, can we do a "#if defined" around it?
> > +       NetOurNativeVLAN = getenv_VLAN("nvlan");
> > +       NetOurVLAN = getenv_VLAN("vlan");

We probably could, but we then had to do this in several places, and
the code would become less readable, I think.


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Q:  How many DEC repairman does it take to fix a flat ?
A:  Five; four to hold the car up and one to swap tires.


More information about the U-Boot mailing list