[U-Boot] [PATCH 12/13] at91: add hardware i2c drivers

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Mon Mar 30 10:50:11 CEST 2009


> >>> +#ifndef AT91_TWI_H
> >>> +#define AT91_TWI_H
> >>> +
> >>> +#define	AT91_TWI_CR		0x00		/* Control Register */
> >>> +#define		AT91_TWI_START		(1 <<  0)	/* Send a Start Condition */
> >>> +#define		AT91_TWI_STOP		(1 <<  1)	/* Send a Stop Condition */
> >>> +#define		AT91_TWI_MSEN		(1 <<  2)	/* Master Transfer Enable */
> >>> +#define		AT91_TWI_MSDIS		(1 <<  3)	/* Master Transfer Disable */
> >>> +#define		AT91_TWI_SVEN		(1 <<  4)	/* Slave Transfer Enable [SAM9260 only] */
> >>> +#define		AT91_TWI_SVDIS		(1 <<  5)	/* Slave Transfer Disable [SAM9260 only] */
> >>> +#define		AT91_TWI_SWRST		(1 <<  7)	/* Software Reset */
> >>>   
> >>                  ^^^^^^^^^^^^^^^
> >>                  doule tabs breaks line length (this affects for the
> >> whole file)
> >>
> > I'll prefer to keep it as it because it's an import from Linux
> 
> Hmm.. maybe this should be fixed in Linux too.
IMHO no because the double tab was use to align but field of the register

Best Regards,
J.


More information about the U-Boot mailing list