[U-Boot] [PATCH] Add "source" command; prepare removal of "autoscr" command

[Peter Tyser]

The changes look good to me.  2 comments below:

> +/*
> + * Keep for now for backward compatibility;
> + * remove later when support for "autoscr" goes away.
> + */
> +U_BOOT_CMD(
> +	autoscr, 2, 0,	do_source,
> +	"run script from memory",
> +	"[addr] - run script starting at addr"
> +	" - A valid image header must be present\n"
> +#if defined(CONFIG_FIT)
> +	"For FIT format uImage addr must include subimage\n"
> +	"unit name in the form of addr:<subimg_uname>\n"
> +#endif
> +);

I'd vote to change autoscr's help messages to something letting end
user's know that the command is deprecated and being replaced by the
"source".  Eg something like:

+ autoscr, 2, 0, do_source,
+ "DEPRECATED - see 'source' command",
+ "DEPRECATED - see 'source' command"

Most U-Boot user's are more likely to see this than the
feature-removal-schedule.txt in the source code.

> +#endif
> diff --git a/doc/feature-removal-schedule.txt b/doc/feature-removal-schedule.txt
> index 9ba7a04..cd429a4 100644
> --- a/doc/feature-removal-schedule.txt
> +++ b/doc/feature-removal-schedule.txt
> @@ -8,12 +8,20 @@ file.
>  ---------------------------
>  
>  What:	"autoscr" command
> -When:	August 2009
> -Why:	"autosrc" is an ugly and completely non-standard name.  The "autoscr"
> -	command is deprecated and will be replaced the "source" command as
> -	used by other shells such as bash.  Both commands will be supported
> -	for a transition period of 6 months after which "autoscr" will be
> -	removed.
> +When:	Release 2009-09
> +
> +Why:	"autosrc" is an ugly and completely non-standard name.
> +        The "autoscr" command is deprecated and will be replaced by
> +

There's an out of place newline here.

> +        the "source" command as used by other shells such as bash.
> +
> +        Starting with March 2009, both commands will be supported for
> +        a transition period of 6 months after which "autoscr" will be
> +        removed. During the transition period existing scripts and
> +        environment variable names remain untouched for maximum
> +        compatibiltiy; thse will be changed when support for the
> +        "autoscr" command get's finally dropped.

s/compatibiltiy/compatibility/ s/thse/these/ and s/get's finally/finally
gets/

Best,
Peter