[U-Boot] [PATCH V2] mpc5200: reduce delays in i2c

Jon Smirl jonsmirl at gmail.com
Tue Mar 31 23:15:15 CEST 2009


On Tue, Mar 31, 2009 at 4:54 PM, Wolfgang Denk <wd at denx.de> wrote:
> Dear Jon Smirl,
>
> In message <20090331010330.20946.41742.stgit at localhost> you wrote:
>> Make the i2c delays smaller. The measured delay is 55us at
>> 100Khz. Set the delay to 15us which should work for 400Khz.
>> 100Khz will loop four times and get a 60us delay. Previous
>> total delay was 100,000us new total delay is 150,000us before
>> timeout.
>
> I think you did not even bother to read my comments to your previous
> patch (foar from trying to understand and react on them).
>
> Sorry, NAK.  Please at least answer the questions you've been asked.

You said:
"I agree that the change itself looks harmless,  and  I'm  willing  to
accept  it,  but  at  least make sure not to reduce the total timeout
values - that would require re-testing on some boards."

I made the total time out bigger just to be extra sure, but I could
lower it back to 100ms.

If this isn't ok. Just drop the patch and I'll keep it in my private tree.


>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> "I dislike companies that have a we-are-the-high-priests-of-hardware-
> so-you'll-like-what-we-give-you attitude. I like commodity markets in
> which iron-and-silicon hawkers know that they exist to  provide  fast
> toys for software types like me to play with..."    - Eric S. Raymond
>



-- 
Jon Smirl
jonsmirl at gmail.com


More information about the U-Boot mailing list