[U-Boot] [PATCH V2] arm: timer and interrupt init rework

[Wolfgang Denk]

Dear Dirk,

In message <49FB7F1A.6090101 at googlemail.com> you wrote:
> 
> > --- a/cpu/arm_cortexa8/omap3/Makefile
> > +++ b/cpu/arm_cortexa8/omap3/Makefile
> > @@ -26,7 +26,13 @@ include $(TOPDIR)/config.mk
> >  LIB	=  $(obj)lib$(SOC).a
> >  
> >  SOBJS	:= lowlevel_init.o
> > -COBJS	:= sys_info.o board.o clock.o interrupts.o mem.o syslib.o
> > +
> > +COBJS	+= board.o
> > +COBJS	+= clock.o
> > +COBJS	+= mem.o
> > +COBJS	+= syslib.o
> > +COBJS	+= sys_info.o
> > +COBJS	+= timer.o
> 
> What do we win with this?
> 
> Why is this related to a patch named "timer and interrupt init rework"?
> 
> Maybe I'm wrong, but it's my feeling that you would reject something 
> like this with e.g. "NACK, don't mix different clean up in one patch. 
> Please split into several patches"? ;)

Indeed. The patch needs to be split.

> > diff --git a/lib_arm/board.c b/lib_arm/board.c
> > index 5d05d9b..b678a63 100644
> > --- a/lib_arm/board.c
> > +++ b/lib_arm/board.c
> > @@ -265,8 +265,11 @@ init_fnc_t *init_sequence[] = {
> >  #if defined(CONFIG_ARCH_CPU_INIT)
> >  	arch_cpu_init,		/* basic arch cpu dependent setup */
> >  #endif
> > -	board_init,		/* basic board dependent setup */
> > +#if defined(CONFIG_USE_IRQ)
> >  	interrupt_init,		/* set up exceptions */
> > +#endif
> > +	timer_init,		/* initialize timer */
> > +	board_init,		/* basic board dependent setup */
> >  	env_init,		/* initialize environment */
> >  	init_baudrate,		/* initialze baudrate settings */
> >  	serial_init,		/* serial communications setup */
> 
> ... if you tested this on an OMAP3 board: I'm not sure, but it seems 
> to me that the initialization order might change by this?
> 
> Old order: board_init -> interrupt_init (including timer_init)
> 
> New order: timer_init -> board_init

Well spotted.

Jean-Christophe - what is your rationale for this change?


Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
How many NASA managers does it take to screw in a lightbulb?  "That's
a known problem... don't worry about it."