[U-Boot] [PATCH 4/6] fsl_esdhc: Add device tree fixups

[Andy Fleming]

On Apr 29, 2009, at 4:20 PM, Anton Vorontsov wrote:

> Hi Andy,
>
> Sorry for the late response,
>
> On Fri, Mar 06, 2009 at 07:25:55PM -0600, Andy Fleming wrote:
>>>
>>>
>>>
>>> @@ -346,3 +348,23 @@ int fsl_esdhc_mmc_init(bd_t *bis)
>>> Â {
>>> Â  Â  Â  Â return esdhc_initialize(bis);
>>> Â }
>>> +
>>> +#ifdef CONFIG_MPC85xx
>>> +#define ESDHC_COMPATIBLE "fsl,mpc8536-esdhc"
>>> +#else
>>> +#define ESDHC_COMPATIBLE "fsl,mpc8379-esdhc"
>>> +#endif
>>
>> Isn't there a more global means of doing this?  I don't like having
>> the 8536/8379 in the driver, itself.
>
> But that's how we prefer bindings nowadays.
>
>> Actually, there is.  Move these
>> to the config file.  But there should be a compatible property that
>> works for all esdhc devices.
>
> Starting from MPC83xx/MPC85xx GPIO controllers, we try to
> differentiate 85xx and 83xx parts. I.e. 85xx family doesn't
> specify 83xx family's compatible entries, even if the controllers
> are compatible. I'm just following the trend.

I'm not strongly interested in arguing about what the compatible  
should be.  Don't specify it here.  Put it in the config file.