[U-Boot] [PATCH v4] Marvell MV88F6281GTW_GE Board support

[Prafulla Wadaskar]

Thanks Jean...

> > +
> > +#include <common.h>
> > +#include <../drivers/net/phy/mv88e61xx.h>
> Ben I not sure it's clean
> any better idea?
> > +#include <netdev.h>
> > +#include "mv88f6281gtw_ge.h"
> > +
> > +DECLARE_GLOBAL_DATA_PTR;
> > +
> > +int board_init(void)
> > +{
> please add comment
Okay 
> > +	kw_config_gpio(MV88F6281GTW_GE_OE_VAL_LOW,
> > +		       MV88F6281GTW_GE_OE_VAL_HIGH,
> > +		       MV88F6281GTW_GE_OE_LOW, MV88F6281GTW_GE_OE_HIGH);
> > +
> > +	/* Multi-Purpose Pins Functionality configuration */
> > +	kw_config_mpp(MV88F6281GTW_GE_MPP0_7,
> > +		      MV88F6281GTW_GE_MPP8_15,
> > +		      MV88F6281GTW_GE_MPP16_23,
> > +		      MV88F6281GTW_GE_MPP24_31,
> > +		      MV88F6281GTW_GE_MPP32_39,
> > +		      MV88F6281GTW_GE_MPP40_47, 
> MV88F6281GTW_GE_MPP48_55);
> > +
> From
> > +	/* serial config */
> > +	gd->baudrate = CONFIG_BAUDRATE;
> againt please remove
Okay

> > index 0000000..9695f3f
> > --- /dev/null
> > +++ b/board/Marvell/mv88f6281gtw_ge/u-boot.lds
> please move to cpu/arm/kirkwood/
I tried it, If we move it to Kirkwood there is build error, how do we invoke it for the build?
currently it provides boot from DRAM since doimage (utility to convert u-boot.bin to flashable bin) is outside. I think this is board specific and each board will have different configuration, for ex. Board with boot from NAND will have different info
 
> > +#define CONFIG_KIRKWOOD		1	/* SOC Family Name */
> > +#define CONFIG_KW88F6281	1	/* SOC Name */
> please define the CONFIG_MACH
Okay I will check this and do the needful

> > +
> > +#ifdef CONFIG_KIRKWOOD
> as I guess it will be always KIRKWOOD please remove
Sounds good, I will remove it

Regards..
Prafulla . .