[U-Boot] [PATCH v5] Marvell MV88F6281GTW_GE Board support

[Prafulla Wadaskar]

> 	+ * along with this program; if not, write to the Free Software
> 	+ * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
> 	+ * MA 02110-1301 USA
> 	+ */
> 	+
> 	
> 	+#include <common.h>
> 	+#include <../drivers/net/phy/mv88e61xx.h>
> 
> If this header is meant to be public it should be in 
> "include".  Sorry I didn't catch that earlier.
> <snip>
This header has some public and some driver specific information
Only a configuration structure in this file is needed here,
I can put it in netdev.h but I didn't find such implementation there.
How about creating a new header file for phy/switch?

> 
> 	+/*
> 	+ * Ethernet Driver configuration
> 	+ */
> 	+#ifdef CONFIG_CMD_NET
> 	+#define CONFIG_NETCONSOLE      /* include NetConsole 
> support   */
> 	+#define CONFIG_NET_MULTI       /* specify more that 
> one ports available */
> 	+#define        CONFIG_MII              /* expose smi 
> ove miiphy interface */
> 	+#define CONFIG_KIRKWOOD_EGIGA  /* Enable kirkwood Gbe 
> Controller Driver */
> 
> This EGIGA driver hasn't been accepted yet.  In fact, I think 
> you've only sent one spin.  It needs to be in before this board... 
You are correct,
I am ready with the latest spin, but it has close dependency with kirkwood SoC layer, once this gets through I had a plan to release egiga driver patch. BTW code builds cleanly without egiga driver so I do not want to remove this :-) since it will be required afterward once kirkwood_egiga driver gets in.
Any suggestion welcomed ???

Regards..
Prafulla . .