[U-Boot] [RFC PATCH] console/device: rework function naming

Wolfgang Denk wd at denx.de
Sun May 3 22:05:45 CEST 2009


Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20090503184226.GY25959 at game.jcrosoft.org> you wrote:
>
> > > we now switch to console_XX and console_device_t
-----------------------^^^^^^^^^^
>
> > Actually there is even a direct name  conflict  -  console_init()  is
> > already  in  use  (in board/netphone/phone_console.c), and your patch
> > fails to resolve this conflict.
> it does, it's call consoles_init()

Then your comment (see above) and the code disagree.

> > Maybe "stdio" would be a better choice than "console" here?
> why not

Hm... actually checking the code tells that stdio is already taken,
too - see show_stdio_dev(), stdio_devices[], stdio_names[].

But at least thesere are only few identifiers, so this could be delt
with.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Where there's no emotion, there's no motive for violence.
	-- Spock, "Dagger of the Mind", stardate 2715.1


More information about the U-Boot mailing list