[U-Boot] [PATCH v5] Marvell MV88F6281GTW_GE Board support

[Ben Warren]

On Sun, May 3, 2009 at 8:45 PM, Prafulla Wadaskar <prafulla at marvell.com>wrote:

> >       >
> >       >       +#include <common.h>
> >       >       +#include <../drivers/net/phy/mv88e61xx.h>
> >       >
> >       > If this header is meant to be public it should be in
> >       > "include".  Sorry I didn't catch that earlier.
> >       > <snip>
> >
> >       This header has some public and some driver specific information
> >       Only a configuration structure in this file is needed here,
> >       I can put it in netdev.h but I didn't find such
> > implementation there.
> >       How about creating a new header file for phy/switch?
> >
> >
> > I think it's appropriate to put the struct definition and
> > public prototypes in netdev.h.  There's a lot of work in
> > progress regarding PHYs, and I may move the prototypes later,
> > but for now netdev is it.  Unless the driver-specific stuff
> > will be used in the future by other drivers, we may as well
> > move it back to the .c file.  I know, I know, I made you
> > create the header file in the first place :)
> > Would you believe that some people have called me indecisive?
> Dear Ben, that's okay,
> For evolving projects like u-boot, the positive progress happens in this
> direction only.
> How do we improve if we don't experiment... :-)
>
> Currently there is only switch_init function header in netdev.h I will put
> a struct definition too.
> Thus we can remove mv88361xx.h dependency in board specific files
>
> Just let me know - shall I send a delta for this or clean patch v9 for
> MV88E61XX driver?
> If I send you clean patch, you may need to revert earlier patch on your
> branch
>
Either is fine with me, although since a v9 would probably be cleaner.

>
> Regards..
> Prafulla . .
>
> >

regards,Ben