[U-Boot] [PATCH] ARM: unbreak PXA build by defining UP2OCR

[Wolfgang Denk]

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20090504224128.GF13923 at game.jcrosoft.org> you wrote:
>
> > > > U-Boot does not currently build for PXA platforms with USB support
> > > > enabled. This is due to commit 24e37645e7378b20fa8f20e2996c8fb8e9
> > > > which introduced the usage of UP2OCR without defining it.
> > > > 
> > > > Signed-off-by: Daniel Mack <daniel at caiaq.de>
> > > > Cc: Markus Klotzbuecher <mk at denx.de>
> > > NACK
> > > 
> > > UP2OCR is not avaaillable for the pxa2xx
> > > 
> > > we need to clean it really
> > 
> > So who is going to do that, and when?
> > 
> > BTW - how many PXA platforms with USB support do we have, and how many
> > of these are pxa2xx ? 
> the usb driver use the same file for supporting all the PXA
> and as it's store in a generic header. We must define the register only
> the specific pxa version and when the same register could mean differents
> things depending the pxa version

That's the theory.  Praxis is that we have a bug, and we need a fix.
And we seem to have one.


You did not answer my questiosn:

- how many PXA platforms with USB support do we have?
- how many of these are pxa2xx?

In other words - is your concern a real problem, or just a theoretical
one?


As far as I can tell, "delta" is the only PXA based board which has
USB enabled. And this is not a pxa2xx.


As mentioned before, I'd rather see a quick fix for a real build
problem now, instead of waiting for a perfect solution that is mostly
of theoretical interest which comes much later.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Often it is fatal to live too long.                          - Racine