[U-Boot] [PATCH v9] Marvell MV88E61XX Switch Driver support

[Prafulla Wadaskar]

> -----Original Message-----
> From: Ben Warren [mailto:biggerbadderben at gmail.com] 
> Sent: Tuesday, May 05, 2009 4:12 AM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; 
> Ronen Shitrit
> Subject: Re: [U-Boot] [PATCH v9] Marvell MV88E61XX Switch 
> Driver support
> 
> Hi Prafulla,
> 
> Prafulla Wadaskar wrote:
> <snip>
> > diff --git a/include/netdev.h b/include/netdev.h index 
> > b73aa8e..932d986 100644
> > --- a/include/netdev.h
> > +++ b/include/netdev.h
> > @@ -28,6 +28,34 @@
> >  #ifndef _NETDEV_H_
> >  #define _NETDEV_H_
> >  
> > +/* constants for switch configuration */ enum switch_cfg_vlan {
> > +	SWITCH_VLANCFG_DEFAULT,
> > +	SWITCH_VLANCFG_ROUTER
> > +};
> > +
> > +enum switch_cfg_rgmiid {
> > +	SWITCH_RGMII_DELAY_DIS,
> > +	SWITCH_RGMII_DELAY_EN
> > +};
> > +
> > +enum switch_cfg_prtstt {
> > +	SWITCH_PORTSTT_DISABLED,
> > +	SWITCH_PORTSTT_BLOCKING,
> > +	SWITCH_PORTSTT_LEARNING,
> > +	SWITCH_PORTSTT_FORWARDING
> > +};
> > +
> > +/* switch configuration structure */
> > +struct switch_config {
> > +	char *name;
> > +	enum switch_cfg_vlan vlancfg;
> > +	enum switch_cfg_rgmiid rgmii_delay;
> > +	enum switch_cfg_prtstt portstate;
> > +	u32 ports_enabled;
> > +	u8 cpuport;
> > +};
> > +
> >   
> Now you're in a common file, so namespaces are important.  
> Keep in mind that while yours is the first switch here, it 
> probably won't be the last and nobody else is bound to using 
> your definitions.  Please qualify all of these names so it's 
> obvious what hardware they refer to.
It makes more sense to revert back to the MV88E61XX names
I will do it..

> 
> Please add this stuff to the bottom of this file, and add an 
> appropriate comment block in the same theme as I've done with 
> the others.
Sure...

Regards..
Prafulla . .

> 
> regards,
> Ben
>