[U-Boot] [PATCH] ARM: unbreak PXA build by defining UP2OCR

Daniel Mack daniel at caiaq.de
Tue May 5 12:16:06 CEST 2009


On Tue, May 05, 2009 at 12:58:57AM +0200, Wolfgang Denk wrote:
> > the usb driver use the same file for supporting all the PXA
> > and as it's store in a generic header. We must define the register only
> > the specific pxa version and when the same register could mean differents
> > things depending the pxa version
> 
> That's the theory.  Praxis is that we have a bug, and we need a fix.
> And we seem to have one.

Correct. It does not build anymore. Another possibility is to revert the
commit which caused the trouble and make Markus Klotzbuecher fix it in a
way Jean-Christophe PLAGNIOL-VILLARD likes.

> - how many PXA platforms with USB support do we have?

That's not the point. I for myself won't bring my board support into
U-Boot's mainline (at least not now) because that would help nobody as
nobody except for me has the hardware the code was written for. And I
guess I'm not the only one.

IMO hings should compile, even when the config for this is not in your
repository; hope you agree.

> In other words - is your concern a real problem, or just a theoretical
> one?

Code using that macro is guarded by MONAHANS #ifdefs anyway, his point
is solely not to have it in the register headers.

Daniel



More information about the U-Boot mailing list