[U-Boot] [PATCH v2] mtd: nand: new base driver for memory mapped nand devices
Scott Wood
scottwood at freescale.com
Wed May 6 20:19:07 CEST 2009
Mike Frysinger wrote:
>>> +/* #define CONFIG_NAND_PLAT */
>> Why is this commented out?
>
> because it's a driver for an optional add-on card that people usually dont
> have, let alone plugged in
OK, was hoping there would be at least one config that selects it so it
gets compilation exposure.
>>> +#define NAND_PLAT_DEV_READY(chip) ((*pPORTFIO & BFIN_NAND_READY) ?
>>> 1 : 0)
>> Why not just (*pPORTFIO & BFIN_NAND_READY)?
>
> i thought the nand/mtd layers expect 1/0 only ? if the higher layers dont
> care, then there's no reason.
A quick grep doesn't show any non-boolean uses.
-Scott
More information about the U-Boot
mailing list