[U-Boot] [PATCH] ARM: unbreak PXA build by defining UP2OCR

Wolfgang Denk wd at denx.de
Thu May 7 23:00:22 CEST 2009


Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <20090507203647.GA3302 at game.jcrosoft.org> you wrote:
> On 12:48 Tue 05 May     , Daniel Mack wrote:
> > U-Boot does not currently build for PXA platforms with USB support
> > enabled. This is due to commit 24e37645e7378b20fa8f20e2996c8fb8e9
> > which introduced the usage of UP2OCR without defining it.
> unfortunatly it's the invert this commit remove it
> 
> please fix the comment

Can you please run a "git show 24e37645" again?

To me it seems that this commit

- removed the usage of UP2OCR from board/delta/delta.c
but also
- added the usage of UP2OCR to the new file cpu/pxa/usb.c
without defining it.


So the comment seems absolutely correct to me. Maybe I'm missing
something?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
We do not colonize. We conquer. We rule. There is no  other  way  for
us.
	-- Rojan, "By Any Other Name", stardate 4657.5


More information about the U-Boot mailing list