[U-Boot] [PATCH] OMAP3: Introduce CONFIG option for power code

[Dirk Behme]

Dear Jean-Christophe,

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 17:21 Wed 06 May     , Dirk Behme wrote:
>> Some OMAP3 boards need control for external power companion
>> chips. Introduce a CONFIG option for this, to avoid Makefile
>> changes for each board.
> 
> please also move it to cpu/arm_cortexa8/omap3/
> 
> omap3 and davinci is not a vendor
> so common code will need to go to drivers or cpu/<arch>/<soc>

No, this wouldn't be correct. We used board/omap3/common/ for this 
intentionally.

We talk about *board* specific code here, it is totally unrelated to 
<arch> or the <soc> we use. This board specific code configures an 
OMAP3 (SoC) external companion chip which is on the board (or not). 
Some boards which share the basic layout have this companion chip, 
some not. Please note that original config options (we remove with 
this patch) were the *board* config options (e.g. CONFIG_OMAP3_BEAGLE) 
to enable the compilation of power.c, too.

> Best Regards,
> J.

I nearly missed your comment below because of this ;)

>> Signed-off-by: Dirk Behme <dirk.behme at googlemail.com>
>> ---
>>
>> Compile tested with ./MAKEALL ARM_CORTEX_A8, boot tested on
>> OMAP3 based BeagleBoard.
>>
>> Note: This patch trys to fix the first comment of
>>
>> http://lists.denx.de/pipermail/u-boot/2009-April/051383.html
>>
>>  board/omap3/common/Makefile     |    5 +----
>>  doc/README.omap3                |   11 +++++++++++
>>  include/configs/omap3_beagle.h  |    1 +
>>  include/configs/omap3_overo.h   |    1 +
>>  include/configs/omap3_pandora.h |    1 +
>>  include/configs/omap3_zoom1.h   |    1 +
>>  6 files changed, 16 insertions(+), 4 deletions(-)
>>
>> Index: u-boot-main/doc/README.omap3
>> ===================================================================
>> --- u-boot-main.orig/doc/README.omap3
>> +++ u-boot-main/doc/README.omap3
>> @@ -77,6 +77,17 @@ For all other commands see
>>  
>>  help
>>  
>> +Custom configs
>> +==============
>> +
>> +CONFIG_OMAP3_POWER
>> +
>> +Some OMAP3 boards use external power companion chips to be configured. Enable
>> +this CONFIG option in your board specific configuration file if your board
>> +uses such a companion chip.
> could you name it ine the config and the file name

Sorry, I don't understand what you want here. What should I name 
where? Which file name?

Dirk