[U-Boot] [PATCH v4] ARM DaVinci Adding DM357 Support

[Paulraj, Sandeep]

Jean-Christophe,
		    Please see inline

> -----Original Message-----
> From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj at jcrosoft.com]
> Sent: Saturday, May 09, 2009 10:08 AM
> To: Paulraj, Sandeep
> Cc: u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH v4] ARM DaVinci Adding DM357 Support
> 
> > +
> > +#ifndef __CONFIG_H
> > +#define __CONFIG_H
> > +#include <asm/sizes.h>
> > +
> > +/*
> > + *
> > + */
> > +#define DM357_EVM
> > +#define CONFIG_SYS_NAND_SMALLPAGE
> > +#define CONFIG_SYS_USE_NAND
> > +/*
> > + * SoC Configuration
> > + */
> > +#define CONFIG_ARM926EJS			/* arm926ejs CPU core */
> > +#define CONFIG_SYS_CLK_FREQ	270000000	/* Arm Clock frequency */
> > +#define CONFIG_SYS_TIMERBASE		0x01c21400	/* use timer 0 */
> why not use a corresponfing macor?
[Sandeep] will do in next patch
> > +#define CONFIG_SYS_HZ_CLOCK		27000000	/* timer frequency
> */
> please use CONFIG_SYS_CLK_FREQ
[Sandeep] no ARM frequency is 270 MHz, timer frequency is 27Mhz
> > +#define CONFIG_SYS_HZ			1000
> > +#define CONFIG_SOC_DM644X
> > +/*
> > + * definitions for EEPROM on DM357 EVM
> > + */
> > +#define CONFIG_SYS_I2C_EEPROM_ADDR_LEN		2
> > +#define CONFIG_SYS_I2C_EEPROM_ADDR		0x50
> > +#define CONFIG_SYS_EEPROM_PAGE_WRITE_BITS	6
> > +#define CONFIG_SYS_EEPROM_PAGE_WRITE_DELAY_MS	20
> > +/*
> > + * Memory Info
> > + */
> > +#define CONFIG_SYS_MALLOC_LEN		(0x10000 + 128 * 1024)
> ??
> why not 192 * 1024?
[Sandeep] will do
> > +#define CONFIG_SYS_GBL_DATA_SIZE	128
> > +#define CONFIG_SYS_MEMTEST_START	0x80000000	/* memtest start */
> > +#define CONFIG_SYS_MEMTEST_END		0x81000000	/* 16MB RAM test */
> > +#define CONFIG_NR_DRAM_BANKS	1		/* we have 1 bank of DRAM
> */
> > +#define CONFIG_STACKSIZE	(256 * 1024)	/* regular stack */
> > +#define PHYS_SDRAM_1		0x80000000	/* DDR Start */
> any macro availlable?
[Sandeep] yes. Address in next patch
> > +#define PHYS_SDRAM_1_SIZE	0x10000000	/* DDR size 256MB */
> > +#define DDR_8BANKS				/* 8-bank DDR2 (256MB) */
> > +/*
> > + * Serial Driver info
> > + */
> > +#define CONFIG_SYS_NS16550
> > +#define CONFIG_SYS_NS16550_SERIAL
> > +#define CONFIG_SYS_NS16550_REG_SIZE	-4
> > +#define CONFIG_SYS_NS16550_COM1	0x01c20000	/* Base address of UART0
> */
> > +#define CONFIG_SYS_NS16550_CLK		27000000	/* Input clock */
> please use CONFIG_SYS_CLK_FREQ
[Sandeep] no it is 27 Mhz so use CONFIG_SYS_HZ_CLOCK. I will address it in next patch
> > +#define CONFIG_CONS_INDEX	1		/* use UART0 for console */
> > +#define CONFIG_BAUDRATE		115200		/* Default baud rate
> */
> > +#define CONFIG_SYS_BAUDRATE_TABLE	{ 9600, 19200, 38400, 57600,
> 115200 }
> > +/*
> > + * I2C Configuration
> > + */
> > +#define CONFIG_HARD_I2C
> > +#define CONFIG_DRIVER_DAVINCI_I2C
> > +#define CONFIG_SYS_I2C_SPEED		80000
> > +#define CONFIG_SYS_I2C_SLAVE		10
> > +/*
> > + * Flash & Environment
> > + */
> <snip>
> > +#define CONFIG_SKIP_LOWLEVEL_INIT	/* U-Boot is loaded by a
> bootloader */
> > +#define CONFIG_SKIP_RELOCATE_UBOOT	/* to a proper address, init
> done */
> > +#define CONFIG_SYS_NAND_BASE		0x02000000
> any macro availlable?
> > +#define CONFIG_SYS_NAND_HW_ECC
> > +#define CONFIG_SYS_MAX_NAND_DEVICE	1
> > +#define CONFIG_ENV_OFFSET		0x0
> > +#endif
> > +/*
> > + * U-Boot general configuration
> > + */
> > +#undef	CONFIG_USE_IRQ			/* No IRQ/FIQ in U-Boot */
> > +#define CONFIG_MISC_INIT_R
> > +#undef CONFIG_BOOTDELAY
> > +#define CONFIG_BOOTFILE			"uImage"	/* Boot file name */
> > +#define CONFIG_SYS_PROMPT		"DM357 EVM > "	/* Command Prompt */
> > +#define CONFIG_SYS_CBSIZE		1024
> > +#define CONFIG_SYS_PBSIZE		(CONFIG_SYS_CBSIZE + \
> > +						sizeof(CONFIG_SYS_PROMPT) + 16)
> > +#define CONFIG_SYS_MAXARGS		16
> > +#define CONFIG_SYS_BARGSIZE		CONFIG_SYS_CBSIZE
> > +#define CONFIG_SYS_LOAD_ADDR		0x80700000
> > +#define CONFIG_VERSION_VARIABLE
> > +#define CONFIG_CMDLINE_EDITING
> > +/*
> > + * Linux Information
> > + */
> > +#define LINUX_BOOT_PARAM_ADDR	0x80000100
> why?
[Sandeep] I will get rid of this
> 
> > +#define CONFIG_CMDLINE_TAG
> > +#define CONFIG_SETUP_MEMORY_TAGS
> > +/*
> > + * U-Boot commands
> > + */
> > +#include <config_cmd_default.h>
> > +#define CONFIG_CMD_ASKENV
> > +#define CONFIG_CMD_DHCP
> > +#define CONFIG_CMD_DIAG
> > +#define CONFIG_CMD_I2C
> > +#define CONFIG_CMD_MII
> > +#define CONFIG_CMD_PING
> > +#define CONFIG_CMD_SAVES
> > +#define CONFIG_CMD_EEPROM
> > +#undef CONFIG_CMD_BDI
> > +#undef CONFIG_CMD_FPGA
> > +#undef CONFIG_CMD_SETGETDCR
> > +#undef CONFIG_CMD_FLASH
> > +#undef CONFIG_CMD_IMLS
> > +#define CONFIG_CMD_NAND
> > +#define CONFIG_CMD_JFFS2
> > +/*
> > + * KGDB support (if any)
> > + */
> > +#ifdef CONFIG_CMD_KGDB
> > +#define CONFIG_KGDB_BAUDRATE	115200	/* speed to run kgdb
> serial port */
> > +#define CONFIG_KGDB_SER_INDEX	1	/* which serial port to use */
> > +#endif
> please remove the kgdb as it's not supported
[Sandeep] OK
> 
> Best Regards,
> J.
Thanks,
Sandeep