[U-Boot] [PATCH v2 2/3] MX31: Add basic support for Freescale i.MX31 PDK board.

Sat May 9 23:17:12 CEST 2009

> +++ b/board/freescale/mx31pdk/lowlevel_init.S
> @@ -0,0 +1,30 @@
> +/*
> + * (C) Copyright 2008 Magnus Lilja <lilja.magnus at gmail.com>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +/*
> + * This is just to keep the linker happy.
> + */
> +
> +.globl lowlevel_init
> +
> +lowlevel_init:
> +	mov	pc, lr
why do you need it?
> diff --git a/board/freescale/mx31pdk/mx31pdk.c b/board/freescale/mx31pdk/mx31pdk.c
> new file mode 100644
> index 0000000..9eed979
> --- /dev/null
> +++ b/board/freescale/mx31pdk/mx31pdk.c
> @@ -0,0 +1,76 @@
> +/*
> + *
> + * (C) Copyright 2008 Magnus Lilja <lilja.magnus at gmail.com>
> + *
> + * (c) 2007 Pengutronix, Sascha Hauer <s.hauer at pengutronix.de>
> + *
> + * See file CREDITS for list of people who contributed to this
> + * project.
> + *
> + * This program is free software; you can redistribute it and/or
> + * modify it under the terms of the GNU General Public License as
> + * published by the Free Software Foundation; either version 2 of
> + * the License, or (at your option) any later version.
> + *
> + * This program is distributed in the hope that it will be useful,
> + * but WITHOUT ANY WARRANTY; without even the implied warranty of
> + * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> + * GNU General Public License for more details.
> + *
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +
> +#include <common.h>
> +#include <asm/arch/mx31.h>
> +#include <asm/arch/mx31-regs.h>
> +
> +DECLARE_GLOBAL_DATA_PTR;
> +
> +int dram_init(void)
> +{
> +	gd->bd->bi_dram[0].start = PHYS_SDRAM_1;
> +	gd->bd->bi_dram[0].size = PHYS_SDRAM_1_SIZE;
> +
> +	return 0;
> +}
> +
> +int board_init(void)
> +{
> +	/* CS5: CPLD incl. network controller */
> +	__REG(CSCR_U(5)) = 0x0000d843;
> +	__REG(CSCR_L(5)) = 0x22252521;
> +	__REG(CSCR_A(5)) = 0x22220a00;
> +
> +	/* setup pins for UART1 */
> +	mx31_gpio_mux(MUX_RXD1__UART1_RXD_MUX);
> +	mx31_gpio_mux(MUX_TXD1__UART1_TXD_MUX);
> +	mx31_gpio_mux(MUX_RTS1__UART1_RTS_B);
> +	mx31_gpio_mux(MUX_CTS1__UART1_CTS_B);
I think it's time to create common device init functions
as done for davinci or at91
> +
> +	/* SPI2 */
> +	mx31_gpio_mux(MUX_CSPI2_SS2__CSPI2_SS2_B);
> +	mx31_gpio_mux(MUX_CSPI2_SCLK__CSPI2_CLK);
> +	mx31_gpio_mux(MUX_CSPI2_SPI_RDY__CSPI2_DATAREADY_B);
> +	mx31_gpio_mux(MUX_CSPI2_MOSI__CSPI2_MOSI);
> +	mx31_gpio_mux(MUX_CSPI2_MISO__CSPI2_MISO);
> +	mx31_gpio_mux(MUX_CSPI2_SS0__CSPI2_SS0_B);
> +	mx31_gpio_mux(MUX_CSPI2_SS1__CSPI2_SS1_B);
ditto
> +
> +	/* start SPI2 clock */
> +	__REG(CCM_CGR2) = __REG(CCM_CGR2) | (3 << 4);
> +
> +	gd->bd->bi_arch_number = MACH_TYPE_MX31_3DS; /* board id for linux */
> +	gd->bd->bi_boot_params = 0x80000100; /* adress of boot parameters */
please use this style

RAM_BASE + 0x100
as other arm board
> +
> +	return 0;
> +}
> +
> diff --git a/board/freescale/mx31pdk/u-boot.lds b/board/freescale/mx31pdk/u-boot.lds
> new file mode 100644
> index 0000000..e96509a
> --- /dev/null
> +++ b/board/freescale/mx31pdk/u-boot.lds
I've send a patch that unify all arm lds so this one is not anymore needed
> @@ -0,0 +1,59 @@
> +/*
> + * You should have received a copy of the GNU General Public License
> + * along with this program; if not, write to the Free Software
> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
> + * MA 02111-1307 USA
> + */
> +
> +#ifndef __CONFIG_H
> +#define __CONFIG_H
> +
> +#include <asm/arch/mx31-regs.h>
why?
> +
> +/* High Level Configuration Options */
> +#define CONFIG_ARM1136		1    /* This is an arm1136 CPU core */
					 ^^^^
whitespate please remove
> +#define CONFIG_MX31		1    /* in a mx31 */
				 ^^^^
whitespate please remove
> +#define CONFIG_MX31_HCLK_FREQ	26000000
> +#define CONFIG_MX31_CLK32	32768
> +
> +#define CONFIG_DISPLAY_CPUINFO
> +#define CONFIG_DISPLAY_BOARDINFO
> +
> +#define CONFIG_CMDLINE_TAG		1    /* enable passing of ATAGs */
					 ^^^^
whitespate please remove
> +#define CONFIG_SETUP_MEMORY_TAGS	1
> +#define CONFIG_INITRD_TAG		1
> +
> +/* No support for NAND boot for i.MX31 PDK yet, so we rely on some other
> + * program to initialize the SDRAM.
> + */
> +#define CONFIG_SKIP_LOWLEVEL_INIT
> +
> +/*
> + * Size of malloc() pool
> + */
> +#define CONFIG_SYS_MALLOC_LEN		(CONFIG_ENV_SIZE + 128 * 1024)
> +/* Bytes reserved for initial data */
> +#define CONFIG_SYS_GBL_DATA_SIZE	128
> +
> +/*
> + * Hardware drivers
> + */
> +
> +#define CONFIG_MX31_UART	1
> +#define CONFIG_SYS_MX31_UART1	1
> +
> +#define CONFIG_HARD_SPI		1
> +#define CONFIG_MXC_SPI		1
> +#define CONFIG_DEFAULT_SPI_BUS	1
> +#define CONFIG_DEFAULT_SPI_MODE	(SPI_MODE_2 | SPI_CS_HIGH)
> +
> +#define CONFIG_RTC_MC13783	1
> +
> +/* MC13783 connected to CSPI2 and SS2 */
> +#define CONFIG_MC13783_SPI_BUS	1
> +#define CONFIG_MC13783_SPI_CS	2
> +
> +/* allow to overwrite serial and ethaddr */
> +#define CONFIG_ENV_OVERWRITE
> +#define CONFIG_CONS_INDEX		1
> +#define CONFIG_BAUDRATE			115200
> +#define CONFIG_SYS_BAUDRATE_TABLE	{9600, 19200, 38400, 57600, 115200}
> +
> +/***********************************************************
> + * Command definition
> + ***********************************************************/
> +
> +#include <config_cmd_default.h>
> +
> +#define CONFIG_CMD_MII
> +#define CONFIG_CMD_PING
> +#define CONFIG_CMD_SPI
> +#define CONFIG_CMD_DATE
> +
> +/* Disabled due to compilation errors in cmd_bootm.c (IMLS seems to require
> + * that CFG_NO_FLASH is undefined).
> + */
please remove the comment
> +#undef CONFIG_CMD_IMLS
> +
> +#define CONFIG_BOOTDELAY	3
> +
> +#define	CONFIG_EXTRA_ENV_SETTINGS					\
> +	"bootargs_base=setenv bootargs console=ttymxc0,115200\0"	\
> +	"bootargs_nfs=setenv bootargs $(bootargs) root=/dev/nfs "	\
> +		"ip=dhcp nfsroot=$(serverip):$(nfsrootfs),v3,tcp\0"	\
> +	"bootcmd=run bootcmd_net\0"					\
> +	"bootcmd_net=run bootargs_base bootargs_mtd bootargs_nfs; "	\
> +		"tftpboot 0x81000000 uImage-mx31; bootm\0"
> +
> +#define CONFIG_DRIVER_SMC911X		1
> +#define CONFIG_DRIVER_SMC911X_BASE	CS5_BASE
> +#define CONFIG_DRIVER_SMC911X_32_BIT	1
> +
> +/*
> + * Miscellaneous configurable options
> + */
> +#define CONFIG_SYS_LONGHELP	/* undef to save memory */
> +#define CONFIG_SYS_PROMPT	"uboot> "
> +#define CONFIG_SYS_CBSIZE	256  /* Console I/O Buffer Size */
				   ^^
whitespate please remove
> +/* Print Buffer Size */
> +#define CONFIG_SYS_PBSIZE	(CONFIG_SYS_CBSIZE + \
> +				sizeof(CONFIG_SYS_PROMPT)+16)
> +/* max number of command args */
> +#define CONFIG_SYS_MAXARGS	16
> +/* Boot Argument Buffer Size */
> +#define CONFIG_SYS_BARGSIZE	CONFIG_SYS_CBSIZE
> +
> +#define CONFIG_SYS_MEMTEST_START	PHYS_SDRAM_1  /* memtest works on */
						    ^^
whitespate please remove
> +#define CONFIG_SYS_MEMTEST_END		0x10000
> +
> +#define CONFIG_SYS_LOAD_ADDR		0x81000000 /* default load address */
> +
> +#define CONFIG_SYS_HZ			1000
> +
> +#define CONFIG_CMDLINE_EDITING	1
> +
> +/*-----------------------------------------------------------------------
> + * Stack sizes
> + *
> + * The stack sizes are set up in start.S using the settings below
> + */
> +#define CONFIG_STACKSIZE	(128 * 1024) /* regular stack */
> +
> +/*-----------------------------------------------------------------------
> + * Physical Memory Map
> + */
> +#define CONFIG_NR_DRAM_BANKS	1
> +#define PHYS_SDRAM_1		CSD0_BASE
> +#define PHYS_SDRAM_1_SIZE	(128 * 1024 * 1024)
> +
> +/*-----------------------------------------------------------------------
> + * FLASH and environment organization
> + */
> +/* No NOR flash present */
> +#define CONFIG_SYS_NO_FLASH	1
> +
> +#define CONFIG_ENV_IS_NOWHERE 	1
				^
whitespate please remove

Best Regards,
J.