[U-Boot] [PATCH 22/29] cpu/mpc512x/i2c.c: use immr offsets from C struct instead of #define

Wolfgang Denk wd at denx.de
Sun May 10 19:49:43 CEST 2009


Dear Heiko,

In message <4A0700C4.5040209 at denx.de> you wrote:
> 
> > Would you prefer if I squashed these commits into one? I can do that,
> > of course. But I found debugging easier as is now...
> 
> No it is fine for me, I just sequentially read the EMails, so I saw
> the patch, which uses the in/out accessors later ;-)

Yes, I know - for reviewing the stuff the split into small steps is
not optimal. BUt I found it very useful for debugging.

> Hmm... I think the complete patchseries go through the mpc5xxx custodian,
> so I only have to ACK this patches, right?

Indeed.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
A Freudian slip is when you say one thing but mean your mother.


More information about the U-Boot mailing list