[U-Boot] [PATCH v2] ppc4xx: Add Sequoia RAM-booting target

[Wolfgang Denk]

Dear Stefan Roese,

In message <200905111339.28531.sr at denx.de> you wrote:
> 
> > > Please note that this image automatically scans for an already
> > > initialized SDRAM TLB (detected by EPN=0). This TLB will not be
> >
> > And what happens when the TLB is not correctly set? Will we get a
> > useful error message then?
> 
> No. SDRAM needs to work correctly so that this RAM-booting version can 
> function. And for this the MMU needs to be configured and the SDRAM controller 
> setup correctly. If this is not the case and SDRAM is not working from the 
> debugger then we have no chance to load this image without problems (verify 
> will most likely fail) or run it.

Hm... if the image cannot run anyway without initialized SDRAM TLB,
then why do you scan for it?  My understanding is that the result
wouldbe the same even if you omitted this test: without initialized
SDRAM TLB the system would just hang / crash without error message.
So this test is dead code.

Or am I missing something?

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Our universe is a fragile house of atoms, held together by the mortar
of cause-and-effect. One magician would be two too many.
                        - Terry Pratchett, _The Dark Side of the Sun_