[U-Boot] [PATCH 00/29] Rework MPC512x Support

Wolfgang Denk wd at denx.de
Tue May 12 23:21:53 CEST 2009


Dear Kim Phillips,

In message <20090512150139.a110609b.kim.phillips at freescale.com> you wrote:
>
> there seem to be recurring themes among these patches - this
> patchseries would be better grouped into theme based content instead of
> on a file by file basis.  Eg., Removal of mpc512x.h shouldn't need 10
> "prepare to remove" patches - it should be a single patch that removes
> all #include references, plus the file removal itself.

You are right, there should be just a single patch.  But  that  patch
would  be  big,  and  if  it  later turns out that I missed something
during my testing, it will be a nightmare to debug.

Been there before. I already had such a patch  stack,  which  I  then
collapsed  into  a small number of handy commits. Until it turned out
that there was a nasty bug somewhere.  And  there  is  no  "unsquash"
option  to  "git-besect  -i" yet ;-) In the end, I had to restore the
previous version from backup tape.

I really thought about this, and I came to the conclusion that it's
better to keep the commits separate, step by step.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Ill-chosen abstraction is particularly evident in the design  of  the
ADA  runtime  system.  The  interface to the ADA runtime system is so
opaque that it is impossible to model  or  predict  its  performance,
making it effectively useless for real-time systems.
                              - Marc D.  Donner and David H. Jameson.


More information about the U-Boot mailing list