[U-Boot] [PATCH 2/4] omap3: remove typedef for struct gpmc

Jean-Christophe PLAGNIOL-VILLARD plagnioj at jcrosoft.com
Wed May 13 00:38:10 CEST 2009


> >  
> > -typedef struct gpmc {
> > +struct gpmc {
> >  	unsigned char res1[0x10];
> >  	unsigned int sysconfig;		/* 0x10 */
> >  	unsigned char res2[0x4];
> > @@ -125,7 +125,7 @@ typedef struct gpmc {
> >  	unsigned int ecc7_result;	/* 0x218 */
> >  	unsigned int ecc8_result;	/* 0x21C */
> >  	unsigned int ecc9_result;	/* 0x220 */
> > -} gpmc_t;
> > +};
> 
> I wonder if you have the resources and like to convert all register 
> structs used by OMAP3 code and remove the typedef?
> 
> Else we would have a mixture of typedefs and struct usage (see e.g. 
> above in sys_info.c). I would like to have it consistent, either the 
> one or the other way ;) What do you think?

Fully agree

Best Regards,
J.


More information about the U-Boot mailing list