[U-Boot] [PATCH] video: ct6900: Add an option to skip video initialization
Stefan Roese
sr at denx.de
Thu May 14 17:17:43 CEST 2009
On Thursday 14 May 2009 17:01:46 Wolfgang Denk wrote:
> > > If this should be the highest level in the call chain, then any
> > > conditional calling should be done here.
> >
> > OK, I can move the conditional calling to this level.
>
> I'm not sure.
>
> > > But - don't we already have
> > > a board_video_init() which could return proper status to abort
> > > initialization?
> >
> > This is only implemented for some video drivers (SM501, SED13806,
> > MB826xx) to return the base address for the graphics chip. The PCI
> > drivers like the ct6900 don't use this interface. Here we have other
> > means to get the base address.
> >
> > I'll move the conditional calling to the highest level and resubmit.
>
> I'd probably rahter see that you add a board_video_init() to the
> ct6900 driver, and have this bail out.
And what should this function return? The base address is already available in
the driver. Should we move this to all boards using this driver? I don't think
so.
> Anatolij, what do you thik is the best solution here?
Yes? What's your preference here?
Thanks.
Best regards,
Stefan
=====================================================================
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80 Email: office at denx.de
=====================================================================
More information about the U-Boot
mailing list