[U-Boot] [PATCH] Redundant Environment: protect full sector size

Stefan Roese sr at denx.de
Fri May 15 09:28:31 CEST 2009


On Friday 15 May 2009 00:16:03 Wolfgang Denk wrote:
> Several boards used different ways to specify the size of the
> protected area when enabling flash write protection for the sectors
> holding the environment variables: some used CONFIG_ENV_SIZE and
> CONFIG_ENV_SIZE_REDUND, some used CONFIG_ENV_SECT_SIZE, and some even
> a mix of both for the "normal" and the "redundant" areas.
>
> Normally, this makes no difference at all. However, things are
> different when you have to deal with boards that can come with
> different types of flash chips, which may have different sector
> sizes.
>
> Here we may have to chose CONFIG_ENV_SECT_SIZE such that it fits the
> biggest sector size, which may include several sectors on boards using
> the smaller sector flash types. In such a case, using CONFIG_ENV_SIZE
> or CONFIG_ENV_SIZE_REDUND to enable the protection may lead to the
> case that only the first of these sectors get protected, while the
> following ones aren't.
>
> This is no real problem, but it can be confusing for the user -
> especially on boards that use CONFIG_ENV_SECT_SIZE to protect the
> "normal" areas, while using CONFIG_ENV_SIZE_REDUND for the
> "redundant" area.
>
> To avoid such inconsistencies, I changed all sucn boards that I found
> to consistently use CONFIG_ENV_SECT_SIZE for protection. This should
> not cause any functional changes to the code.
>
> Signed-off-by: Wolfgang Denk <wd at denx.de>
> Cc: Paul Ruhland
> Cc: Pantelis Antoniou <panto at intracom.gr>
> Cc: Stefan Roese <sr at denx.de>
> Cc: Gary Jennejohn <garyj at denx.de>
> Cc: Dave Ellis <DGE at sixnetio.com>

Acked-by: Stefan Roese <sr at denx.de>

Thanks.

Best regards,
Stefan

=====================================================================
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: +49-8142-66989-0 Fax: +49-8142-66989-80  Email: office at denx.de
=====================================================================


More information about the U-Boot mailing list