[U-Boot] [PATCH v3] IDE: bail out of dev_print() for unknown device types

Wolfgang Denk wd at denx.de
Fri May 15 22:30:32 CEST 2009


In message <1242372478-8446-1-git-send-email-wd at denx.de> you wrote:
> Commit 574b319512 introduced a subtle bug by mixing a list of tests
> for "dev_desc->type" and "dev_desc->if_type" into one switch(), which
> then mostly did not work because "dev_desc->type" cannot take any
> "IF_*" type values. A later fix in commit 8ec6e332ea changed the
> switch() into testing "dev_desc->if_type", but at this point the
> initial test for unknown device types was completely lost, which
> resulted in output like that for IDE ports without device attached:
> 
>   Device 1: Model:  Firm:  Ser#:
>             Type: # 1F #
>             Capacity: not available
> 
> This patch re-introduces the missing test for unknown device types.
> 
> Signed-off-by: Wolfgang Denk <wd at denx.de>
> Cc: Stefan Roese <sr at denx.de>
> Cc: Detlev Zundel <dzu at denx.de>
> ---
> v2: fix typo
> v3: fix white space
> 
>  disk/part.c |    5 +++++
>  1 files changed, 5 insertions(+), 0 deletions(-)

Applied.


Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If some day we are defeated, well, war has  its  fortunes,  good  and
bad.
	-- Commander Kor, "Errand of Mercy", stardate 3201.7


More information about the U-Boot mailing list