[U-Boot] [PATCH 1/2] drv_video_init(): simplify logic

Wolfgang Denk wd at denx.de
Sat May 16 09:28:34 CEST 2009


Dear Anatolij Gustschin,

In message <4A0DF8CD.9030504 at denx.de> you wrote:
> > Simplify nesting of drv_video_init() and use a consistent way of
> > indicating failure / success. Before, it took me some time to realize
> > which of the returns was due to an error condition and which of them
> > indicated success.
> > 
> > Signed-off-by: Wolfgang Denk <wd at denx.de>
> > Cc: Anatolij Gustschin <agust at denx.de>
> > ---
> >  drivers/video/cfb_console.c |   69 ++++++++++++++++++-------------------------
> >  1 files changed, 29 insertions(+), 40 deletions(-)
> 
> Applied to u-boot-video/next, Thanks!

Thank you.

> Note that i also fixed a missing semicolon after
> 'skip_dev_init = (video_init () == -1)' statement in both
> patches before applying.

Ouch. Thanks for catching this.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Being schizophrenic is better than living alone.


More information about the U-Boot mailing list