[U-Boot] [PATCH 1/1] arm: unify some CONFIGs

[Wolfgang Denk]

Dear Jean-Christophe PLAGNIOL-VILLARD,

In message <1242593505-27370-1-git-send-email-plagnioj at jcrosoft.com> you wrote:
> all arm boards share the same following define
> 
> size in bytes reserved for initial data
> CONFIG_SYS_GBL_DATA_SIZE
> 
> max number of command args
> CONFIG_SYS_MAXARGS
> 
> IRQ stack
> CONFIG_STACKSIZE_IRQ
> 
> FIQ stack
> CONFIG_STACKSIZE_FIQ

I think many boards share other defines as well; I don't think that
splitting these few lines off is really something that improves the
code.

> diff --git a/include/asm-arm/config.h b/include/asm-arm/config.h
> index 049c44e..795b53d 100644
> --- a/include/asm-arm/config.h
> +++ b/include/asm-arm/config.h
> @@ -21,4 +21,16 @@
>  #ifndef _ASM_CONFIG_H_
>  #define _ASM_CONFIG_H_
>  
> +/* size in bytes reserved for initial data */
> +#define CONFIG_SYS_GBL_DATA_SIZE	128
> +
> +/* max number of command args */
> +#define CONFIG_SYS_MAXARGS		16
> +
> +/* IRQ stack */
> +#define CONFIG_STACKSIZE_IRQ		(4 * 1024)
> +
> +/* FIQ stack */
> +#define CONFIG_STACKSIZE_FIQ		(4 * 1024)

NAK. All config related information shall remain in the
include/configs/ directory only.


Also, this patch makes it impossible for a board to chose different
configurations.

Assume a board wants to use more than 16 arguments. With your patch, a
global, common file would need to be changed for such a simple thing.

This is contra-productive.


Sorry, but full NAK.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
If something is different, it's either better or worse,  and  usually
both.                                                    - Larry Wall