[U-Boot] [PATCH] ARM DaVinci Leopard Board Support
Paulraj, Sandeep
s-paulraj at ti.com
Mon May 18 22:54:06 CEST 2009
Wolfgang,
I think what JC means is to use something like
#define CONFIG_SYS_NAND_BASE_LIST { DAVINCI_NAND_BASE, }
Now this info is available in the hardware.h file for DaVinci but it
requires a little tweak. I just sent another patch to address that
[PATCH] ARM DaVinci Minor Change to header file
Let me know if this is OK. Then I can use MACROs in the config.h file.
Jean-Christophe,
Is this new patch OK with you?
Thanks,
Sandeep
> -----Original Message-----
> From: Wolfgang Denk [mailto:wd at denx.de]
> Sent: Monday, May 18, 2009 4:47 PM
> To: Jean-Christophe PLAGNIOL-VILLARD
> Cc: Paulraj, Sandeep; u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH] ARM DaVinci Leopard Board Support
>
> Dear Jean-Christophe PLAGNIOL-VILLARD,
>
> In message <20090518202149.GG17539 at game.jcrosoft.org> you wrote:
> >
> > > +#ifndef __CONFIG_H
> > > +#define __CONFIG_H
> > > +#include <asm/sizes.h>
> > > +
> > > +
> > > +#define DAVINCI_LEOPARD
> > please CONFIG_
>
> Or rather CONFIG_SYS_DAVINCI_LEOPARD
>
> This is not a user-0selectable parameter, and such are fobidden
> outside the board config files anyway.
>
> > > +#define CONFIG_SYS_NAND_SMALLPAGE
> > > +#define CONFIG_SYS_NAND_BASE_LIST { 0x02000000, }
> > please use macro
>
> ??? Please explain what you mean here. This is a macro, isn't it?
>
> > > +/* U-Boot general configuration */
> > > +#undef CONFIG_USE_IRQ /* No
> IRQ/FIQ in U-Boot */
> > > +#define CONFIG_BOOTFILE "uImage" /* Boot
> file name */
> > > +#define CONFIG_SYS_PROMPT "LEOPARD EVM # "
> > > +#define CONFIG_SYS_CBSIZE 1024 /*
> Console I/O Buffer Size */
> > why 1k?
>
> Why not? That's a config option...
>
> Best regards,
>
> Wolfgang Denk
>
> --
> DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
> HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
> Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
> A Freudian slip is when you say one thing but mean your mother.
>
>
More information about the U-Boot
mailing list