[U-Boot] [PATCH] fix accidental erase of OneNand whole chip

[Scott Wood]

On Mon, May 18, 2009 at 08:00:43PM +0800, Geiger Ho wrote:
> This patch fixes the accidental erase of OneNand whole chip when issuing 
> command "onenand erase".
> 
> Signed-off-by: Geiger Ho <geiger.ho at fmp.fujitsu.com>
> 
> 
> --- u-boot-2009.03/common/cmd_onenand.c	2009-03-22 05:04:41.000000000 +0800
> +++ u-boot-2009.03-dev/common/cmd_onenand.c	2009-05-18 
> 17:57:27.000000000 +0800
> @@ -367,6 +367,8 @@ int do_onenand(cmd_tbl_t * cmdtp, int fl
>   			return 0;
>   		}
> 
> +		goto usage;
> +
>   	default:
>   		/* At least 4 args */
> 

While that "at least 4 args" comment seems wrong, I don't think this
patch is correct -- there is code in the default block that checks argc
and expects to get there with argc == 2 in some cases.

How does accidental erasing occur?

-Scott