[U-Boot] [PATCH 06/15] drivers/qe: Change QE RISC ALLOCATION to support 4 RISCs
Wolfgang Denk
wd at denx.de
Wed May 20 21:37:27 CEST 2009
Dear Haiying Wang,
In message <1242837043-8243-6-git-send-email-Haiying.Wang at freescale.com> you wrote:
> Also define the QE_RISC_ALLOCATION_RISCs to MACROs instead of using enum, and
> define MAX_QE_RISC for QE based silicons.
>
> Signed-off-by: Haiying Wang <Haiying.Wang at freescale.com>
> Acked-by: Timur Tabi <timur at freescale.com>
...
> +#if (MAX_QE_RISC == 4)
> + .riscTx = QE_RISC_ALLOCATION_FOUR_RISCS,
> + .riscRx = QE_RISC_ALLOCATION_FOUR_RISCS,
> +#else
> .riscTx = QE_RISC_ALLOCATION_RISC1_AND_RISC2,
> .riscRx = QE_RISC_ALLOCATION_RISC1_AND_RISC2,
> +#endif
Is there a chance to get rid of these camel-case identifiers? They
violate the CodingStyle....
Best regards,
Wolfgang Denk
--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
After a time, you may find that "having" is not so pleasing a thing,
after all, as "wanting." It is not logical, but it is often true.
-- Spock, "Amok Time", stardate 3372.7
More information about the U-Boot
mailing list