[U-Boot] [PATCH 1/3] smc911x: write back the manually set MAC address

Dirk Behme dirk.behme at googlemail.com
Thu May 21 07:03:39 CEST 2009


Ben Warren wrote:
> Daniel Mack wrote:
>> If the MAX address is given by the environment, write it back to the
>> hardware.
>>
>> Signed-off-by: Daniel Mack <daniel at caiaq.de>
>> Cc: Sascha Hauer <s.hauer at pengutronix.de>
>> ---
>>  drivers/net/smc911x.c |    9 +++++++--
>>  1 files changed, 7 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/net/smc911x.c b/drivers/net/smc911x.c
>> index 30f2dc2..8c9a2a8 100644
>> --- a/drivers/net/smc911x.c
>> +++ b/drivers/net/smc911x.c
>> @@ -41,8 +41,13 @@ static int smx911x_handle_mac_address(bd_t *bd)
>>  	unsigned long addrh, addrl;
>>  	uchar m[6];
>>  
>> -	/* if the environment has a valid mac address then use it */
>> -	if (!eth_getenv_enetaddr("ethaddr", m)) {
>> +	if (eth_getenv_enetaddr("ethaddr", m)) {
>> +		/* if the environment has a valid mac address then use it */
>> +		addrl = m[0] | (m[1] << 8) | (m[2] << 16) | (m[3] << 24);
>> +		addrh = m[4] | (m[5] << 8);
>> +		smc911x_set_mac_csr(ADDRL, addrl);
>> +		smc911x_set_mac_csr(ADDRH, addrh);
>> +	} else {
>>  		/* if not, try to get one from the eeprom */
>>  		addrh = smc911x_get_mac_csr(ADDRH);
>>  		addrl = smc911x_get_mac_csr(ADDRL);
> Applied to net/next branch.

Could we get this asap into mainline? Sounds like an urgent bugfix to me:

http://lists.denx.de/pipermail/u-boot/2009-May/053079.html

Many thanks

Dirk



More information about the U-Boot mailing list